fix(ci): restore Generate PR Body as separate step#359
Merged
marcusrbrown merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
fro-bot
approved these changes
Mar 22, 2026
Owner
fro-bot
left a comment
There was a problem hiding this comment.
Approval
This fix correctly addresses the TITLE_SUFFIX: unbound variable crash in the Release job.
Root Cause Analysis
On main, the heredoc inside the "Semantic Release" step references:
${TITLE_SUFFIX}${COMMIT_LIST}${TIMESTAMP}
But these are never defined in that shell context. The workflow uses bash -Eeuxo pipefail (line 22), which includes -u (treat unbound variables as errors). This causes the job to crash.
Fix Verification
The PR correctly:
- Splits the step - Moves PR body generation to its own step after semantic-release
- Defines all variables before use:
VERSIONfrom semantic-release outputsCOMMIT_LISTfrom git logTIMESTAMPfrom date command
- Handles conditionals safely - Uses
if/elseto ensureTITLE_SUFFIXis always defined (not just when VERSION exists)
Minor Observation
The heredoc uses variable interpolation (<<EOF not <<'EOF'), which is correct here since you want the shell to expand ${TITLE_SUFFIX} and ${COMMIT_LIST}. The use of ${COMMIT_LIST:-No new commits} provides a safe default for empty values.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | fro-bot/agent |
| Run ID | 23410141471 |
| Cache | hit |
| Session | ses_2e9159c45ffeU7GIpSQrSHhEYv |
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TITLE_SUFFIX: unbound variablecrash in Release job onmainRoot cause
The Generate PR Body step was accidentally merged into the Semantic Release step without its variable definitions (
TITLE_SUFFIX,COMMIT_LIST,TIMESTAMP). Bash strict mode (set -u) aborts on unbound variables.