Skip to content

Rails 6.1 compatibility #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Rails 6.1 compatibility #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/dynamic_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ def update_attributes(attributes)
set_dynamic_attributes(attributes)
super(attributes)
end

# Overrides update to take dynamic attributes into account
# (Rails 6.1 ActiveRecord deprecates update_attributes methods)
def update(attributes)
set_dynamic_attributes(attributes)
super(attributes)
end

# Creates an accessor when a non-existing setter with the configured dynamic attribute prefix is detected. Calls super otherwise.
def method_missing(method, *arguments, &block)
Expand Down Expand Up @@ -120,7 +127,7 @@ def set_dynamic_attribute(att, value = nil)
update_dynamic_attribute(att, value)
end

# Called on object initialization or when calling update_attributes to convert passed dynamic attributes
# Called on object initialization or when calling update_attributes/update to convert passed dynamic attributes
# into attributes that will be persisted by calling set_dynamic_attribute if it does not exist already.
# The serialization column will also be updated and the detected dynamic attributes are removed from the passed
# attributes hash.
Expand Down