Improve linting and testing behavior

Author: fritz-c

.eslintignore

@@ -0,0 +1,3 @@
+# Disable linting in root directory
+**/*.js
+!src/**/*.js

karma.conf.babel.js

@@ -6,7 +6,7 @@ import KarmaJunitReporter from 'karma-junit-reporter';
 import KarmaSourcemapLoader from 'karma-sourcemap-loader';
 import KarmaPhantomjsLauncher from 'karma-phantomjs-launcher';
 import KarmaNotifyReporter from 'karma-notify-reporter';
-import webpackConfig from './webpack.config.dev.babel';
+import webpackConfig from './webpack.config.test.babel';
 
 export default function setConfig(config) {
     config.set({
@@ -20,7 +20,6 @@ export default function setConfig(config) {
             outputDir: (process.env.CIRCLE_TEST_REPORTS || 'public') + '/karma',
             suite: 'karma'
         },
-        singleRun: true,
         plugins: [
             KarmaCoverage,
             KarmaJasmine,
@@ -39,7 +38,7 @@ export default function setConfig(config) {
             type: 'json'
         },
         notifyReporter: {
-            reportEachFailure: true, // Default: false, Will notify on every failed spec
+            reportEachFailure: false, // Default: false, Will notify on every failed spec
             reportSuccess: false, // Default: true, Will notify when a suite was successful
         },
     });

package.json

@@ -11,13 +11,11 @@
     "clean:umd": "rimraf dist/umd",
     "start": "cross-env NODE_ENV=development webpack-dev-server --hot --inline --config webpack.config.dev.babel.js",
     "lint": "eslint src",
-    "prepublish": "npm run lint && npm run build:umd",
+    "prepublish": "npm run test && npm run build:umd",
     "posttest": "[ -z \"$CI\" ] || codecov",
-    "test": "npm run lint && npm run test:unit",
-    "test:unit": "cross-env NODE_ENV=test karma start",
-    "deploy": "npm run build && gh-pages -d build",
-    "watch": "watch 'clear && npm run test -s' src",
-    "watch:nolint": "watch 'clear && npm run test:unit' src"
+    "test": "cross-env NODE_ENV=test karma start --single-run",
+    "test:watch": "cross-env NODE_ENV=test karma start",
+    "deploy": "npm run build && gh-pages -d build"
   },
   "main": "dist/umd/react-sortable-tree.js",
   "files": [
@@ -52,6 +50,7 @@
     "css-loader": "^0.23.1",
     "eslint": "^3.2.2",
     "eslint-config-blue-hour": "0.x.x",
+    "eslint-loader": "^1.5.0",
     "eslint-plugin-import": "^1.10.2",
     "eslint-plugin-jsx-a11y": "^2.0.1",
     "eslint-plugin-react": "^6.0.0",

src/tests.js

@@ -1,9 +1,9 @@
-import Bluebird from 'bluebird';
+import Bluebird from 'bluebird'; // eslint-disable-line import/no-extraneous-dependencies
 
 // Polyfill a full ES6 environment
 // Reference: https://babeljs.io/docs/usage/polyfill/
 // Reference: https://github.com/zloirock/core-js
-import 'babel-polyfill';
+import 'babel-polyfill'; // eslint-disable-line import/no-extraneous-dependencies
 
 // Replace the scheduler with setImmediate so we can write sync tests
 Bluebird.setScheduler(fn => {

webpack.config.dev.babel.js

@@ -25,6 +25,13 @@ module.exports = {
         autoprefixer,
     ],
     module: {
+        preLoaders: [
+            {
+                test: /\.jsx?$/,
+                loader: 'eslint-loader',
+                include: path.join(__dirname, 'src')
+            },
+        ],
         loaders: [
             {
                 test: /\.jsx?$/,

webpack.config.test.babel.js

@@ -0,0 +1,63 @@
+import HtmlWebpackPlugin from 'html-webpack-plugin';
+import path from 'path';
+import webpack from 'webpack';
+import autoprefixer from 'autoprefixer';
+
+module.exports = {
+    devtool: 'eval',
+    entry: {
+        demo: './src/examples/basicExample/app',
+    },
+    output: {
+        path: 'build',
+        filename: 'static/[name].js',
+    },
+    plugins: [
+        new HtmlWebpackPlugin({
+            filename: 'index.html',
+            inject: true,
+            template: './src/examples/basicExample/index.html'
+        }),
+        new webpack.HotModuleReplacementPlugin(),
+    ],
+    postcss: [
+        autoprefixer,
+    ],
+    module: {
+        preLoaders: [
+            {
+                test: /\.jsx?$/,
+                loader: 'eslint-loader',
+                include: path.join(__dirname, 'src')
+            },
+        ],
+        loaders: [
+            {
+                test: /\.jsx?$/,
+                loaders: ['react-hot', 'babel'],
+                include: path.join(__dirname, 'src')
+            },
+            {
+                test: /\.scss$/,
+                loaders: [
+                    'style-loader',
+                    'css-loader?modules&importLoaders=1&localIdentName=[local]___[hash:base64:5]',
+                    'postcss-loader',
+                    'sass-loader',
+                ],
+                include: path.join(__dirname, 'src')
+            },
+            {
+                test: /\.(jpe?g|png|gif)$/,
+                loaders: [
+                    'file-loader?name=static/[name]-[hash:6].[ext]',
+                ],
+                include: path.join(__dirname, 'src')
+            },
+        ],
+    },
+    devServer: {
+        contentBase: 'build',
+        port: 3001
+    },
+};