Revert automatic linking of React.xcodeproj #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@maicki - still going to merge this? |
Contributor
Author
|
Yeah we should merge this otherwise creating a new lib and link it via |
Contributor
Author
|
cc @frostney Any thoughts? |
Contributor
Author
|
@thorbenprimke Thanks for reviewing |
maicki
added a commit
that referenced
this pull request
Jun 10, 2018
Revert automatic linking of React.xcodepro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic linking with
React.xcodeproj(#44) brokereact-native link. React should not be linked in the libraryxcodeprojas React would be linked twice if you link it in your final React Native project.To work on or test a new library, a new React Native project or a new Xcode Project workspace should be created and the newly created library and React should be linked manually or via
react-native link.A good description how to test a new library with a workspace is in #38 from @DavidPotter.