Skip to content

Change naming for root folder to use more standard format #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2018
Merged

Change naming for root folder to use more standard format #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,15 @@ module.exports = ({
identifier, it is recommended to customize the package identifier.`);
}

return createFolder(name)
const moduleName = rootFolderName = `${modulePrefix}-${paramCase(name)}`;
return createFolder(rootFolderName)
.then(() => {
if (!generateExample) {
return Promise.resolve()
}
// Note: The example has to be created first because it will fail if there
// is already a package.json in the folder in which the command is executed.
return execSync('react-native init example', { cwd: './' + name, stdio:'inherit'});
return execSync('react-native init example', { cwd: './' + rootFolderName, stdio:'inherit'});
})
.then(() => {
return Promise.all(templates.filter((template) => {
Expand All @@ -80,7 +81,7 @@ module.exports = ({
}
const args = {
name: `${prefix}${pascalCase(name)}`,
moduleName: `${modulePrefix}-${paramCase(name)}`,
moduleName,
packageIdentifier,
namespace: namespace || pascalCase(name).split(/(?=[A-Z])/).join('.'),
platforms,
Expand All @@ -90,7 +91,7 @@ module.exports = ({
license,
};

const filename = path.join(name, template.name(args));
const filename = path.join(rootFolderName, template.name(args));
var baseDir = filename.split(path.basename(filename))[0];

return createFolder(baseDir).then(() =>
Expand Down