BlameCommand: Notice when the file is unsaved: #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Querying blame information for a file with unsaved modifications shouldn't be allowed. This is because the line-number of the text caret in the in-memory representation of the file has a high chance of referring to an unrelated line in the on-disk representation of the file. Since `git blame` operates solely with on-disk representation, bogus information could be shown in the phantom because of this discrepancy. BlameShowAllCommand already protects against this.
Collaborator
|
Merged 👍 Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying blame information for a file with unsaved modifications shouldn't be allowed. This is because the line-number of the text caret in the in-memory representation of the file has a high chance of referring to an unrelated line in the on-disk representation of the file. Since
git blameoperates solely with on-disk representation, bogus information could be shown in the phantom because of this discrepancy.BlameShowAllCommand already protects against this.