Skip to content

Use emacs-travis.mk instead of deprecated evm #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2018
Merged

Use emacs-travis.mk instead of deprecated evm #163

merged 2 commits into from
Mar 28, 2018

Conversation

@juergenhoetzel
Copy link
Collaborator

@juergenhoetzel juergenhoetzel commented Mar 28, 2018

Also add emacs-26-pretest and emacs-snapshot to build matrix.

@juergenhoetzel
Use emacs-travis.mk instead of deprecated evm
fad843b 
Also add emacs-26-pretest and emacs-snapshot to build matrix.
@juergenhoetzel
Don't use internal tramp-make-tramp-file-name
29d1c08 
The signature of `tramp-make-tramp-filename` changed in Emacs 26.
@juergenhoetzel
Copy link
Collaborator Author

juergenhoetzel commented Mar 28, 2018

Need fix (dont use internal tramp-make-tramp-file-name) for Emacs-26 compatibility: http://lists.gnu.org/archive/html/tramp-devel/2017-09/msg00001.html

In toplevel form:
fsharp-mode-completion.el:211:10:Error: tramp-make-tramp-file-name called with 4 arguments, but requires 6-7
make: *** [fsharp-mode-completion.elc] Error 1

@juergenhoetzel juergenhoetzel self-assigned this Mar 28, 2018
@juergenhoetzel
Copy link
Collaborator Author

juergenhoetzel commented Mar 28, 2018

Need fix (dont use internal tramp-make-tramp-file-name) for Emacs-26 compatibility: http://lists.gnu.org/archive/html/tramp-devel/2017-09/msg00001.html

Fixed in fad843b

@juergenhoetzel juergenhoetzel merged commit 1309c29 into fsharp:master Mar 28, 2018
juergenhoetzel added a commit to juergenhoetzel/emacs-fsharp-mode that referenced this pull request Nov 30, 2019
@juergenhoetzel
Merge pull request fsharp#163 from juergenhoetzel/master
8509fb1 
Use emacs-travis.mk instead of deprecated evm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@juergenhoetzel juergenhoetzel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@juergenhoetzel