-
Notifications
You must be signed in to change notification settings - Fork 290
Upgrade styles, integrate HTMX and AlpineJS, and enhance testimonials page #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upgrade to tailwind 4 Integrate HTMX Integrate alpineJS Add search to testimonial page Remove news feed
|
The changes look great! I'd be in favour of a font change TBH - I'm no fan of the current font @vzarytovskii WDYT? |
|
Yeah, agree on the font, it renders a bit weird. |
|
Looking around I see some dead links
I think we should drop the "unaffiliated" CSS tags because the FSSF affiliation is no longer as central here. There will be more links to clean-up too, this is a start |
|
Regarding the actual code changes - it's a big change but looking at the site it seems to be working fine. I don't know enough about the different new technologies to comment much more but it seems fine to progress with this and move on - we can always revert if really necessary @vzarytovskii Do you agree? |
Yeah, agree. |
|
@IanWitham I will merge, thanks for the great work and we'd love to see it continue! |
|
@IanWitham There are two CI jobs running, is this as expected? |
|
@dsyme no, that's unexpected. Did you make the following change?
|
|
Thanks for the other feedback too. Happy to get rid of the x.com link with extreme prejudice |
|
@IanWitham Got it, set that now, is it OK now? |
|
@IanWitham looking forward to your next PR then, enjoy the deletion! |
|
Can't see the repo settings, but we'll find out when the next commit happens. |

Various layout changes for a more modern and coherent look.
My changes can be previewed here: https://ianwitham.github.io/fsharp.org/
I was originally trying to just fix the nav menu on mobile, which I have also done. Main changes are:
Note that if merging this, it may be necessary to go to repo settings and change Pages -> Build and Deploy source from "Deploy from Branch" to "Github Actions". This is because tailwind/postcss integration requires a more sophisticated build than is supported by "classic" github pages build.
I fully expect such a major change to generate some discussion before merging.