Skip to content

Move testimonials to a dedicated navbar item #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Move testimonials to a dedicated navbar item #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions _includes/navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
initDarkMode() {
// Set up listener for system preference changes
const darkModeMediaQuery = window.matchMedia('(prefers-color-scheme: dark)');

// Initial check based on system preference if no explicit theme is set
if (this.theme === null && darkModeMediaQuery.matches) {
document.documentElement.classList.add('dark');
}

// Listen for changes in system preference
darkModeMediaQuery.addEventListener('change', (e) => {
if (this.theme === null) {
Expand Down Expand Up @@ -65,8 +65,6 @@
F#</a>
<a href="{{ '/docs' | relative_url }}" role="menuitem" class="group"
tabindex="-1">Documentation</a>
<a href="{{ '/testimonials' | relative_url }}" role="menuitem" class="group"
tabindex="-1">Testimonials</a>
<a href="{{ '/teaching/research' | relative_url }}" role="menuitem" class="group"
tabindex="-1">Publications</a>
<a href="https://www.youtube.com/c/fsharporg" role="menuitem" class="group"
Expand Down Expand Up @@ -109,6 +107,22 @@
</div>
</div>

<div class="nav-item" x-data="{open: false}" @click.away="open= false">
<button type="button" @click="open=!open" x-bind:aria-expanded="open">
Testimonials <i class="fa-solid fa-chevron-down text-white/70 dark:text-slate-950/70"></i>
</button>

<div x-cloak @click="open=false; mobileNavOpen=false;" x-transition x-show="open" role="menu"
aria-orientation="vertical" aria-labelledby="menu-button" tabindex="-1">
<div role="none">
<a href="{{ '/testimonials' | relative_url }}" role="menuitem" class="group"
tabindex="-1">Testimonials</a>
<a href="https://github.com/fsharp/fsharp.org/tree/main?tab=readme-ov-file#testimonials" role="menuitem" class="group"
tabindex="-1">Submit Testimonial</a>
</div>
</div>
</div>

<div class="nav-item" x-data="{open: false}" @click.away="open= false">
<button type="button" @click="open=!open" x-bind:aria-expanded="open">
Community <i class="fa-solid fa-chevron-down text-white/70 dark:text-slate-950/70"></i>
Expand Down Expand Up @@ -182,5 +196,3 @@
</nav>

<div class="htmx-indicator" hx-preserve id="loading-strip"></div>