Improve errors raised, simplify/generalize some code #254
Conversation
| if value >= 0 then | ||
| () | ||
| else | ||
| invalidArg name $"The value must be non-negative, but was {value}." |
There was a problem hiding this comment.
argumentoufofrange? I guess you're refactoring, which answers that...
There was a problem hiding this comment.
I'll double-check, but the errors raised should be the same as for similar functions in Seq.xxx. I vaguely remember being surprised about this previously. It may be because the argument check is immediate, and the range check happens while iterating the sequence (which, in turn, may have a dynamic length).
There was a problem hiding this comment.
I actually started the refactoring to limit some allocations in an upcoming PR (and more generally, to improve the code).
There was a problem hiding this comment.
Forgot about this discussion point. These should be invalidArg. We throw ArgumentOutOfRange if we find that, while iterating, we end up past the last index, for instance. Here, it is clearly an argument error, as there's never an index that's negative.
(this is my interpretation from MS's logic in the same/similar cases for Array/Seq/List)
Just some house-keeping and getting slightly more useful errors in some cases.