Add handling of ResultType static parameter for SqlProgrammabilityProvider #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider: * factorize common logic handling addition of inner types (for record and table types) * fix XML documentation for SqlProgrammabilityProvider * add one test checking the table return type on a function call
Contributor
|
Tests work for me locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking for ideas to add more tests.
It addresses what I initially understood from #257 which is pointing about mixed-up documentation about
ResultTypeI intend to use
ResultType.DataTablein work codebase and I'll need to define.TablemembersNote: I have issues locally to build most of the tests, they expect something different than no parameter at commands' constructor call sites, I haven't been able to compile run all other tests, can somebody confirm the issue?