Skip to content

Bump to Fable 4.27 and adjust ifdef for Fable4 #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 16, 2025
+7 −15
Merged

Bump to Fable 4.27 and adjust ifdef for Fable4 #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
352200d
Bump to Fable 4.27 and adjust ifdef for Fable4
wallymathieu Nov 16, 2025
7d00915
try --test:MSBuildCracker flag
wallymathieu Nov 16, 2025
3840e11
downgrade runner image
wallymathieu Nov 16, 2025
dcec904
try node 24
wallymathieu Nov 16, 2025
1a04772
bump setup node action
wallymathieu Nov 16, 2025
ed878af
try out same command as in fuchu
wallymathieu Nov 16, 2025
b11f0e3
windows latest
wallymathieu Nov 16, 2025
0901cb0
- install global fable
wallymathieu Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"fable": {
"version": "4.23.0",
"version": "4.27.0",
"commands": [
"fable"
]
Expand Down
16 changes: 4 additions & 12 deletions .github/workflows/fable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
testfable4:
runs-on: ubuntu-latest
runs-on: windows-latest

steps:
- uses: actions/checkout@v2
Expand All @@ -26,20 +26,12 @@ jobs:
6.0.x
- name: Restore tools
run: dotnet tool restore
- name: Install jq
uses: dcarbone/install-jq-action@v1.0.1
- name: Install fable
run: |
version=`cat ./.config/dotnet-tools.json | jq --raw-output '.tools.fable.version'`
dotnet tool install --global Fable --version $version
- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: '18.x'
- name: Setup Node.js environment
uses: actions/setup-node@v5
- name: Install npm dependencies
working-directory: tests/FSharpPlusFable.Tests
run: npm install
- name: Run Fable tests
working-directory: tests/FSharpPlusFable.Tests
run: fable . --outDir bin --runScript ./bin
run: dotnet fable . --outDir bin --runScript ./bin /d

2 changes: 1 addition & 1 deletion src/FSharpPlus/Control/Comonad.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ open System.Threading.Tasks
open FSharpPlus
open FSharpPlus.Extensions
open FSharpPlus.Internals
#if !FABLE_COMPILER4
#if !FABLE_COMPILER_4

// Comonad class ----------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion tests/FSharpPlusFable.Tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": true,
"type": "module",
"scripts": {
"test": "fable . --outDir bin --runScript ./bin /d",
"test": "dotnet fable . --outDir bin --runScript ./bin /d",
"test_debug": "node --eval \"require('esm')(module)('./bin/./Tests.js')\" ./bin/./Tests.js ./bin /d"
},
"name": "tests"
Expand Down
Loading