Protocol fixes #64
Merged
Protocol fixes #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linux kernel spec paths corrected
update this branch with upstream commits
… folder inside the notebook's folder.
This allows some libs built against later FSharp.Core.dll to be supported under IfSharp e.g. FAKE.
Substitute in F# 3.1 for later versions
Added loop on the control socket to correctly receive restart requests.
Member
|
Great that's excellent. It leads to much faster kernel starts and restarts for me! |
This was referenced May 6, 2016
Author
|
Also note that the only reasons things were still mostly working was that the browser client was using an outdated version of the ZMQ protocol. Without this change, an upgrade to that by the Jupyter team would have prevented the kernel from working altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed a mistake in handling the identity headers of ZMQ, which was preventing protocol negotiation. The kernel now connects faster with the client.
Also, I've added handling of the control socket, limited to handling the shutdown request packet. This makes kernel restart work properly.