mktemp() → mkstemp()

mktemp() is deprecated:
https://docs.python.org/3/library/tempfile.html#deprecated-functions-and-variables

Author: DimitriPapadopoulos

fsspec/implementations/cached.py

@@ -180,8 +180,8 @@ def save_cache(self):
         for c in cache.values():
             if isinstance(c["blocks"], set):
                 c["blocks"] = list(c["blocks"])
-        fn2 = tempfile.mktemp()
-        with open(fn2, "wb") as f:
+        fd2, fn2 = tempfile.mkstemp()
+        with open(fd2, "wb") as f:
             pickle.dump(cache, f)
         self._mkcache()
         move(fn2, fn)
@@ -723,10 +723,13 @@ class LocalTempFile:
     """A temporary local file, which will be uploaded on commit"""
 
     def __init__(self, fs, path, fn=None, mode="wb", autocommit=True, seek=0):
-        fn = fn or tempfile.mktemp()
+        if fn:
+            self.fn = fn
+            self.fh = open(fn, mode)
+        else:
+            fd, self.fn = tempfile.mkstemp()
+            self.fh = open(fd, mode)
         self.mode = mode
-        self.fn = fn
-        self.fh = open(fn, mode)
         if seek:
             self.fh.seek(seek)
         self.path = path

fsspec/implementations/tests/test_cached.py

@@ -124,7 +124,8 @@ def test_write():
     url = "simplecache::file://" + fn
     with fsspec.open(url, "wb") as f:
         f.write(b"hello")
-        assert fn not in f.name
+        if isinstance(f.name, str):
+            assert fn not in f.name
         assert not os.listdir(tmp)
 
     assert open(fn, "rb").read() == b"hello"