Skip to content

Conversation

@skshetry
Copy link
Contributor

Since this is used in function signatures in put/get/get_file/put_file, which could be used in other implementations, there is no point in hiding DEFAULT_CALLBACK.

Since this is used in function signatures, which could be used in
other implementations, there is no point in hiding DEFAULT_CALLBACK
or making it private with an underscore.
@martindurant
Copy link
Member

This is fine, but I would have argued that _ does not mean "hidden" but "not meant to be called from outside the package".

@martindurant martindurant merged commit 45c5934 into fsspec:master Jan 10, 2024
@skshetry
Copy link
Contributor Author

This is fine, but I would have argued that _ does not mean "hidden" but "not meant to be called from outside the package".

The _DEFAULT_CALLBACK leaves a bad taste IMO, and I don't see a strong reason to discourage it's use. We have a lot of wrapper functions for cross-filesystem transfer operations that use DEFAULT_CALLBACK to match the fsspec.

I don't have a strong opinion. I'll leave the decision up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants