Skip to content

Fix handling of Paths in zip implementation #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix handling of Paths in zip implementation #1689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edf4957
Fix handling of Paths in zip implementation
QuLogic Sep 23, 2024
b64d30a
Merge branch 'master' into zip-path
martindurant Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fsspec/implementations/zip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import zipfile

import fsspec
Expand Down Expand Up @@ -48,7 +49,7 @@ def __init__(
if mode not in set("rwa"):
raise ValueError(f"mode '{mode}' no understood")
self.mode = mode
if isinstance(fo, str):
if isinstance(fo, (str, os.PathLike)):
if mode == "a":
m = "r+b"
else:
Expand Down
Loading