Fix: "Part 6d" - query key type mismatch in newNoteMutation cache update #4171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The useQuery hook uses an array format for queryKey (['notes']), but the
mutation's getQueryData and setQueryData calls were using a string format
('notes'). In TanStack Query v4+, these are treated as completely different
cache keys, preventing the optimistic cache update from working.
This caused the UI to not update after adding a new note because the mutation
was updating a different cache entry than the one being watched by useQuery.
Changed queryClient.getQueryData('notes') to queryClient.getQueryData(['notes'])
and queryClient.setQueryData('notes', ...) to queryClient.setQueryData(['notes'], ...)
to ensure cache consistency and proper UI updates.
ebubecodes
changed the title
The useQuery hook uses an array format for queryKey (['notes']), but the
mutation's getQueryData and setQueryData calls were using a string format
('notes'). In TanStack Query v4+, these are treated as completely different
cache keys, preventing the optimistic cache update from working.
This caused the UI to not update after adding a new note because the mutation
was updating a different cache entry than the one being watched by useQuery.
Changed queryClient.getQueryData('notes') to queryClient.getQueryData(['notes'])
and queryClient.setQueryData('notes', ...) to queryClient.setQueryData(['notes'], ...)
to ensure cache consistency and proper UI updates.
Contributor
Author
|
I pushed a follow-up commit to this branch that addresses the same issue, but in the Finnish translation. No other semantic changes. Thanks!" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
newNoteMutation'sonSuccesshandler uses string format for query keys ('notes'), but theuseQueryhook uses array format (['notes']). In TanStack Query v4+, these are treated as completely different cache entries, causing the UI to not update after adding a new note.Changes
queryClient.getQueryData('notes')→queryClient.getQueryData(['notes'])queryClient.setQueryData('notes', ...)→queryClient.setQueryData(['notes'], ...)Result
The mutation now correctly updates the same cache entry that
useQueryis watching, enabling instant UI updates without triggering an extra GET request (as intended by the optimization in Part 6d).Related
This fixes a bug in the course material implementation from 'Part 6d: React Query, useReducer and the context', "Optimizing the performance" section.