Skip to content

Commit 1850b13

Browse files
authored
ci: improve workflow trigger paths (#9)
* fix `npm run build` for all pkgs (vibe-kanban eeb84602) * Done. Updated the paths configuration in `test-core.yml` to match the mikroorm workflow pattern: - Added `branches: [main]` filter for both push and pull_request - Added `package.json` and `package-lock.json` (dependency changes may affect tests) - Added `.github/workflows/test-core.yml` (workflow changes should trigger a run) * Done. Removed `branches: [main]` from both workflows. They'll now trigger on any branch when the relevant paths change.
1 parent 50ae06e commit 1850b13

File tree

4 files changed

+19
-11
lines changed

4 files changed

+19
-11
lines changed

.github/workflows/test-core.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,15 @@ on:
44
push:
55
paths:
66
- 'packages/core/**'
7+
- 'package.json'
8+
- 'package-lock.json'
9+
- '.github/workflows/test-core.yml'
710
pull_request:
811
paths:
912
- 'packages/core/**'
13+
- 'package.json'
14+
- 'package-lock.json'
15+
- '.github/workflows/test-core.yml'
1016

1117
jobs:
1218
test:

.github/workflows/test-mikroorm-driver.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ name: Test MikroORM Driver
22

33
on:
44
push:
5-
branches: [main]
65
paths:
76
- 'packages/mikroorm-driver/**'
87
- 'packages/core/**'
98
- 'package.json'
109
- 'package-lock.json'
1110
- '.github/workflows/test-mikroorm-driver.yml'
1211
pull_request:
13-
branches: [main]
1412
paths:
1513
- 'packages/mikroorm-driver/**'
1614
- 'packages/core/**'

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
"workspaces": [
55
"packages/*"
66
],
7+
"scripts": {
8+
"build": "npm run build --workspaces"
9+
},
710
"dependencies": {},
811
"devDependencies": {
912
"lerna": "^8.1.8"

packages/mikroorm-driver/src/test/integration.spec.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { describe, it, expect, beforeEach, afterEach } from 'vitest';
33
import { Entity, PrimaryKey, Property, MikroORM } from '@mikro-orm/core';
44
import {
55
TransactionalEventEmitter,
6+
TransactionalEventEmitterOperations,
67
InboxOutboxEvent,
78
IListener,
89
} from '@nestixis/nestjs-inbox-outbox';
@@ -95,7 +96,7 @@ describe('Integration Tests', () => {
9596

9697
const event = new UserCreatedEvent(1, 'test@example.com');
9798

98-
await emitter.emitAsync(event, [{ operation: 'persist' as const, entity: user }]);
99+
await emitter.emitAsync(event, [{ operation: TransactionalEventEmitterOperations.persist, entity: user }]);
99100

100101
const em = orm.em.fork();
101102
const users = await em.find(User, {});
@@ -129,7 +130,7 @@ describe('Integration Tests', () => {
129130

130131
const event = new UserCreatedEvent(2, 'atomic@example.com');
131132

132-
await emitter.emitAsync(event, [{ operation: 'persist' as const, entity: user }]);
133+
await emitter.emitAsync(event, [{ operation: TransactionalEventEmitterOperations.persist, entity: user }]);
133134

134135
const em = orm.em.fork();
135136
const users = await em.find(User, { email: 'atomic@example.com' });
@@ -153,8 +154,8 @@ describe('Integration Tests', () => {
153154
const event = new UserCreatedEvent(1, 'user1@example.com');
154155

155156
await emitter.emit(event, [
156-
{ operation: 'persist' as const, entity: user1 },
157-
{ operation: 'persist' as const, entity: user2 },
157+
{ operation: TransactionalEventEmitterOperations.persist, entity: user1 },
158+
{ operation: TransactionalEventEmitterOperations.persist, entity: user2 },
158159
]);
159160

160161
await new Promise(resolve => setTimeout(resolve, 100));
@@ -193,7 +194,7 @@ describe('Integration Tests', () => {
193194
const userToDelete = await checkEm.findOne(User, { id: userId });
194195

195196
const event = new UserDeletedEvent(userId);
196-
await emitter.emitAsync(event, [{ operation: 'remove' as const, entity: userToDelete! }]);
197+
await emitter.emitAsync(event, [{ operation: TransactionalEventEmitterOperations.remove, entity: userToDelete! }]);
197198

198199
const finalEm = orm.em.fork();
199200
const deletedUser = await finalEm.findOne(User, { id: userId });
@@ -232,7 +233,7 @@ describe('Integration Tests', () => {
232233

233234
const event = new UserCreatedEvent(1, 'listener@example.com');
234235

235-
await emitter.emitAsync(event, [{ operation: 'persist' as const, entity: user }]);
236+
await emitter.emitAsync(event, [{ operation: TransactionalEventEmitterOperations.persist, entity: user }]);
236237

237238
expect(handledEvents).toHaveLength(1);
238239
expect(handledEvents[0].email).toBe('listener@example.com');
@@ -303,7 +304,7 @@ describe('Integration Tests', () => {
303304

304305
const event = new UserCreatedEvent(1, 'multi@example.com');
305306

306-
await emitter.emitAsync(event, [{ operation: 'persist' as const, entity: user }]);
307+
await emitter.emitAsync(event, [{ operation: TransactionalEventEmitterOperations.persist, entity: user }]);
307308

308309
expect(results).toContain('listener1');
309310
expect(results).toContain('listener2');
@@ -374,7 +375,7 @@ describe('Integration Tests', () => {
374375
const beforeEmit = Date.now();
375376
const event = new UserCreatedEvent(1, 'retry@example.com');
376377

377-
await emitter.emitAsync(event, [{ operation: 'persist' as const, entity: user }]);
378+
await emitter.emitAsync(event, [{ operation: TransactionalEventEmitterOperations.persist, entity: user }]);
378379

379380
const em = orm.em.fork();
380381
const transportEvents = await em.find(MikroOrmInboxOutboxTransportEvent, { eventName: 'UserCreated' });
@@ -402,7 +403,7 @@ describe('Integration Tests', () => {
402403
const beforeEmit = Date.now();
403404
const event = new UserCreatedEvent(1, 'expire@example.com');
404405

405-
await emitter.emitAsync(event, [{ operation: 'persist' as const, entity: user }]);
406+
await emitter.emitAsync(event, [{ operation: TransactionalEventEmitterOperations.persist, entity: user }]);
406407

407408
const em = orm.em.fork();
408409
const transportEvents = await em.find(MikroOrmInboxOutboxTransportEvent, { eventName: 'UserCreated' });

0 commit comments

Comments
 (0)