Skip to content

Commit aef49b1

Browse files
authored
Done. I've added TypeScript type-check steps to both CI workflows: (#8)
1. **test-core.yml**: Added a "Type check" step that runs `npm run build` before tests 2. **test-mikroorm-driver.yml**: Added a "Type check MikroORM driver" step that runs `npm run build` on the mikroorm-driver workspace before tests This ensures TypeScript type errors are caught early in CI before tests run, preventing the issue where tests could pass while type errors exist in the code.
1 parent 1850b13 commit aef49b1

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

.github/workflows/test-core.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ jobs:
3131
run: npm install
3232
working-directory: packages/core
3333

34+
- name: Type check
35+
run: npm run build
36+
working-directory: packages/core
37+
3438
- name: Run tests
3539
run: npm run test
3640
working-directory: packages/core

.github/workflows/test-mikroorm-driver.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ jobs:
5151
- name: Build core package
5252
run: npm run build --workspace=@nestixis/nestjs-inbox-outbox
5353

54+
- name: Type check MikroORM driver
55+
run: npm run build --workspace=@nestixis/nestjs-inbox-outbox-mikroorm-driver
56+
5457
- name: Run MikroORM driver tests
5558
run: npm test --workspace=@nestixis/nestjs-inbox-outbox-mikroorm-driver
5659
env:

0 commit comments

Comments
 (0)