Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 12, 2025

Adds test coverage for pl/czak/minimal/R class from CID bafkreibb4gsprc3fvmnyqx6obswvm7e7wngnfj64gz65ey72r7xgyzymt4. The test was failing because the smali parser required a .source directive, but generated resource classes (like R) don't emit one:

.class public final Lpl/czak/minimal/R;
.super Ljava/lang/Object;

# direct methods
.method private constructor <init>()V

vs source-backed classes:

.class public Lpl/czak/minimal/MainActivity;
.super Landroid/app/Activity;
.source "MainActivity.java"

# direct methods

Changes:

  • Made .source directive optional in smali parser by wrapping smaliSourceDeclarationParser with createOptionalParser
  • Updated destructuring to handle optional sourceFile field
  • Added pl/czak/minimal/R to test suite
Original prompt

This section details on the original issue you should resolve

<issue_title>Add bafkreibb4gsprc3fvmnyqx6obswvm7e7wngnfj64gz65ey72r7xgyzymt4 + pl/czak/minimal/R parseDexAgainstSmaliMacro test like others and make it pass</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: futpib <4330357+futpib@users.noreply.github.com>
Copilot AI changed the title [WIP] Add parseDexAgainstSmaliMacro test and make it pass Add pl/czak/minimal/R test and make .source directive optional in smali parser Nov 12, 2025
Copilot AI requested a review from futpib November 12, 2025 20:10
Copilot finished work on behalf of futpib November 12, 2025 20:10
@futpib futpib marked this pull request as ready for review November 12, 2025 20:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19310352746

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 93.912%

Files with Coverage Reduction New Missed Lines %
build/smaliParser.js 1 95.97%
Totals Coverage Status
Change from base Build 19310157815: 0.002%
Covered Lines: 7636
Relevant Lines: 8126

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19310352738

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 93.911%

Files with Coverage Reduction New Missed Lines %
build/smaliParser.js 1 95.97%
Totals Coverage Status
Change from base Build 19310157815: 0.001%
Covered Lines: 7636
Relevant Lines: 8126

💛 - Coveralls

@futpib futpib merged commit b600df2 into master Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bafkreibb4gsprc3fvmnyqx6obswvm7e7wngnfj64gz65ey72r7xgyzymt4 + pl/czak/minimal/R parseDexAgainstSmaliMacro test like others and make it pass

3 participants