-
Notifications
You must be signed in to change notification settings - Fork 1
Implement Format 31c (const-string/jumbo) Dalvik bytecode parser #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: futpib <4330357+futpib@users.noreply.github.com>
DALVIK_MISSING_PARSERS.md
Outdated
|
|
||
| - [ ] **Format 31c** (const-string/jumbo) | ||
| - **Description:** vAA, thing@BBBBBBBB - Constant pool index with 8-bit register | ||
| - [x] **Format 31c** (const-string/jumbo) - ✅ IMPLEMENTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Remove implemented from this file, only keep not implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit 7f00487. Removed all implemented formats from DALVIK_MISSING_PARSERS.md - the file now only lists the 8 missing formats (20bc, 22cs, 35mi, 35ms, 3rmi, 3rms, 45cc, 4rcc).
|
@copilot Put something into copilot instructions so that next rub will not have to "Explore repository structure and understand existing code patterns" or at least do less of it |
Pull Request Test Coverage Report for Build 19213211230Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 19213091735Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove implemented from .md
…missing ones Co-authored-by: futpib <4330357+futpib@users.noreply.github.com>
Implements Format 31c parser for the
const-string/jumboinstruction (opcode 0x1b), the highest priority missing Dalvik bytecode format.Changes
src/dalvikBytecodeParser/formatParsers.ts: AddedcreateDalvikBytecodeFormat31cParserusingubyteParser(8-bit register) anduintParser(32-bit index). Mirrors Format 21c structure but with 32-bit vs 16-bit index.src/dalvikBytecodeParser.ts: AddeddalvikBytecodeOperationConstStringJumboParserwith opcode 0x1b, integrated into operation union parser.DALVIK_MISSING_PARSERS.md: Removed all implemented formats from the file, keeping only the 8 missing/not-yet-implemented formats (20bc, 22cs, 35mi, 35ms, 3rmi, 3rms, 45cc, 4rcc). Updated counts to 24/32 formats (75%).Format Specification
Verified against Android Dalvik Bytecode Specification.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.