Add StandardIntegrityErrorCode test and fix negative hex literal parsing #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test coverage for
com/google/android/play/core/integrity/model/StandardIntegrityErrorCodeclass from DEX CIDbafybeicb3qajmwy6li7hche2nkucvytaxcyxhwhphmi73tgydjzmyoqoda.Changes
Test Coverage: Added
StandardIntegrityErrorCodetotestCasesByCidindalvikExecutableParserAgainstSmaliParser.test.tsParser Fix: Fixed ambiguity in
smaliNumberParserwhere negative hex literals like-0x1matched both hex and decimal parsersThe issue occurred because the negative lookahead only checked for
0x, allowing JSON number parser to consume-while hex parser matched-0x1, causing "Multiple union child parsers succeeded" error.This fix enables parsing of annotation classes with negative hex field initializers (common in Android error code enums).
Original prompt
bafybeicb3qajmwy6li7hche2nkucvytaxcyxhwhphmi73tgydjzmyoqoda+com/google/android/play/core/integrity/model/StandardIntegrityErrorCodeparseDexAgainstSmaliMacro test like others and make it pass #159✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.