Add OpusDecoder test and fix 3-byte int sign extension bug in DEX parser #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for
com/google/android/exoplayer2/ext/opus/OpusDecoderclass parsing. Test initially failed due to incorrect 3-byte integer parsing in the DEX encoded value parser.Bug Fix
The
encodedValueIntParserincorrectly handled sign extension for 3-byte integers in little-endian format:This bug caused
0xbb80(48000) to parse as0xbb80ff(12288255).Changes
OpusDecoderto test suite for CIDbafybeicb3qajmwy6li7hche2nkucvytaxcyxhwhphmi73tgydjzmyoqodaOriginal prompt
bafybeicb3qajmwy6li7hche2nkucvytaxcyxhwhphmi73tgydjzmyoqoda+com/google/android/exoplayer2/ext/opus/OpusDecoderparseDexAgainstSmaliMacro test like others and make it pass #177✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.