Add ClassPackagingData test and fix BigInt precision loss in smali parser #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test case for
ch/qos/logback/classic/spi/ClassPackagingDatawhich exposed a precision loss bug: the smali parser was converting 64-bit hex literals withLsuffix to JavaScript numbers, losing precision beyond 53 bits.Example of the bug:
Changes
smaliParser.ts: ModifiedsmaliHexNumberParserto detectLsuffix and returnBigIntinstead of usingNumber.parseInt()smaliParser.ts: AddedsmaliFieldValueParserunion to support bothnumber | bigintfor field initial values while keeping existing parsers typed asnumberonlysmaliParser.ts: Updated static value detection and array building to handlebiginttypedalvikExecutableParserAgainstSmaliParser.test.ts: Addedch/qos/logback/classic/spi/ClassPackagingDatatest caseOriginal prompt
bafybeibbupm7uzhuq4pa674rb2amxsenbdaoijigmaf4onaodaql4mh7yy+ch/qos/logback/classic/spi/ClassPackagingDataparseDexAgainstSmaliMacro test like others and make it pass #179✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.