Fix parameterAnnotations sorting to use full method signature comparison #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dalvikExecutableUnparser roundtriptest failed with seed=815925079 due to incorrect method matching in the parameterAnnotations sorting logic.Problem
The parser's sorting logic for
parameterAnnotationsonly comparedmethod.nameandmethod.prototype.shorty, ignoringmethod.class. This caused false matches between methods from different classes with identical names and shorty descriptors (e.g.,LA/_;.<init>vsLa/A;.<init>).Fix
Use the existing
dalvikExecutableMethodEqualsfunction for full method signature comparison:Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.