Add openapiv3 request bodies #69 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma91n
commented
Dec 4, 2023
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/ReqPostProducts' | ||
| $ref: '#/components/requestBodies/ReqPostProductsBody' |
Collaborator
Author
There was a problem hiding this comment.
【相談ポイント】
- requestBodiesに全て切る方式なので、patsh各エンドポイントは結構スカスカになるが良いか？
- 400, 500エラーなどと同等の階層になり、一貫性は増すので、これはこれでよいかもしれない、と思っています。
Collaborator
Author
There was a problem hiding this comment.
- すかすかになった関係上、L295~L297のようにここでは命名程度にルールを押さえ、削除部分はcomponents/requestBodiesに引っ越しました
ma91n
commented
Dec 4, 2023
| headers: ... | ||
| examples: ... | ||
| links: ... | ||
| callbacks: ... |
ma91n
commented
Dec 4, 2023
| ... | ||
| example-1: | ||
| $ref: './examples/post-product.example.1.yaml' | ||
| $ref: '#/components/responses/RespPostProducts' |
Collaborator
Author
There was a problem hiding this comment.
レスポンス側も、components/responses に寄せるという方向だったので修正
ma91n
commented
Dec 4, 2023
| ... | ||
| example-1: | ||
| $ref: './examples/post-product.example.1.yaml' | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
宣言の順番的だけ追加。
- エラー部分
- 共通部分
- アプリ個別
利用頻度が高いと思われる順に統合。
おそらく、共通部分はファイル切り出しするとややこしいので、そことの整合性がTODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.