chore: rework some interfaces

Author: ryanatkn

.changeset/shy-views-warn.md

@@ -0,0 +1,5 @@
+---
+'@fuzdev/fuz_gitops': minor
+---
+
+chore: rework some interfaces

src/lib/changeset_generator.ts

@@ -36,7 +36,7 @@ export const create_changeset_for_dependency_updates = async (
 	const changesets_dir = join(repo.repo_dir, '.changeset');
 
 	// Ensure .changeset directory exists
-	if (!fs_ops.exists({path: changesets_dir})) {
+	if (!(await fs_ops.exists({path: changesets_dir}))) {
 		const mkdir_result = await fs_ops.mkdir({path: changesets_dir, recursive: true});
 		if (!mkdir_result.ok) {
 			throw new Error(`Failed to create .changeset directory: ${mkdir_result.message}`);

src/lib/git_operations.ts

@@ -86,9 +86,11 @@ export const git_has_changes = async (options?: SpawnOptions): Promise<boolean>
 };
 
 /**
- * Returns list of changed files compared to HEAD.
+ * Lists uncommitted files in the working tree (`git diff --name-only HEAD`).
  */
-export const git_get_changed_files = async (options?: SpawnOptions): Promise<Array<string>> => {
+export const git_list_uncommitted_files = async (
+	options?: SpawnOptions,
+): Promise<Array<string>> => {
 	const {stdout} = await spawn_out('git', ['diff', '--name-only', 'HEAD'], options);
 	if (!stdout) return [];
 

src/lib/multi_repo_publisher.ts

@@ -337,7 +337,7 @@ export const publish_repos = async (
 				const deploy_result = await ops.process.spawn({
 					cmd: 'gro',
 					args: ['deploy', '--no-build'],
-					spawn_options: {cwd: repo.repo_dir},
+					cwd: repo.repo_dir,
 				});
 
 				if (deploy_result.ok) {
@@ -426,7 +426,7 @@ const publish_single_repo = async (
 	const publish_result = await ops.process.spawn({
 		cmd: 'gro',
 		args: ['publish', '--no-build'],
-		spawn_options: {cwd: repo.repo_dir},
+		cwd: repo.repo_dir,
 	});
 
 	if (!publish_result.ok) {

src/lib/operations.ts

@@ -36,7 +36,6 @@
 
 import type {Result} from '@fuzdev/fuz_util/result.js';
 import type {Logger} from '@fuzdev/fuz_util/log.js';
-import type {SpawnOptions} from 'node:child_process';
 import type {LocalRepo} from './local_repo.js';
 import type {ChangesetInfo} from './changeset_reader.js';
 import type {BumpType} from './semver.js';
@@ -161,9 +160,13 @@ export interface GitOperations {
 	has_changes: (options?: {cwd?: string}) => Promise<Result<{value: boolean}, {message: string}>>;
 
 	/**
-	 * Gets a list of changed files.
+	 * Lists uncommitted files in the working tree (`git diff --name-only HEAD`).
+	 *
+	 * Renamed from `get_changed_files` in 2026-04 because "changed files" collided
+	 * with mageguild's `get_changed_files` which diffs two refs. This one reports
+	 * uncommitted working-tree changes relative to HEAD.
 	 */
-	get_changed_files: (options?: {
+	list_uncommitted_files: (options?: {
 		cwd?: string;
 	}) => Promise<Result<{value: Array<string>}, {message: string}>>;
 
@@ -216,7 +219,7 @@ export interface ProcessOperations {
 	spawn: (options: {
 		cmd: string;
 		args: Array<string>;
-		spawn_options?: SpawnOptions;
+		cwd?: string;
 	}) => Promise<Result<{stdout?: string; stderr?: string}, {message: string; stderr?: string}>>;
 }
 
@@ -331,7 +334,7 @@ export interface FsOperations {
 	/**
 	 * Checks if a path exists on the file system.
 	 */
-	exists: (options: {path: string}) => boolean;
+	exists: (options: {path: string}) => Promise<boolean>;
 }
 
 /**

src/lib/operations_defaults.ts

@@ -8,8 +8,7 @@
  */
 
 import {spawn_out} from '@fuzdev/fuz_util/process.js';
-import {readFile, writeFile, mkdir} from 'node:fs/promises';
-import {existsSync} from 'node:fs';
+import {readFile, writeFile, mkdir, stat} from 'node:fs/promises';
 import {git_checkout, type GitBranch, type GitOrigin} from '@fuzdev/fuz_util/git.js';
 import {EMPTY_OBJECT} from '@fuzdev/fuz_util/object.js';
 
@@ -23,7 +22,7 @@ import {
 	git_tag,
 	git_push_tag,
 	git_has_changes,
-	git_get_changed_files,
+	git_list_uncommitted_files,
 	git_has_file_changed,
 	git_stash,
 	git_stash_pop,
@@ -165,9 +164,9 @@ export const default_git_operations: GitOperations = {
 		return wrap_with_value(() => git_has_changes(cwd ? {cwd} : undefined));
 	},
 
-	get_changed_files: async (options) => {
+	list_uncommitted_files: async (options) => {
 		const {cwd} = options ?? EMPTY_OBJECT;
-		return wrap_with_value(() => git_get_changed_files(cwd ? {cwd} : undefined));
+		return wrap_with_value(() => git_list_uncommitted_files(cwd ? {cwd} : undefined));
 	},
 
 	// Tagging
@@ -203,9 +202,9 @@ export const default_git_operations: GitOperations = {
 
 export const default_process_operations: ProcessOperations = {
 	spawn: async (options) => {
-		const {cmd, args, spawn_options} = options;
+		const {cmd, args, cwd} = options;
 		try {
-			const spawned = await spawn_out(cmd, args, spawn_options);
+			const spawned = await spawn_out(cmd, args, cwd ? {cwd} : undefined);
 			if (spawned.result.ok) {
 				return {
 					ok: true,
@@ -318,8 +317,13 @@ export const default_fs_operations: FsOperations = {
 		return wrap_void(() => mkdir(path, {recursive}));
 	},
 
-	exists: (options) => {
-		return existsSync(options.path);
+	exists: async (options) => {
+		try {
+			await stat(options.path);
+			return true;
+		} catch {
+			return false;
+		}
 	},
 };
 

src/lib/preflight_checks.ts

@@ -99,7 +99,7 @@ export const run_preflight_checks = async ({
 
 		if (!clean_result.value) {
 			// Get list of changed files for better error message
-			const files_result = await git_ops.get_changed_files({cwd: repo.repo_dir}); // eslint-disable-line no-await-in-loop
+			const files_result = await git_ops.list_uncommitted_files({cwd: repo.repo_dir}); // eslint-disable-line no-await-in-loop
 			if (files_result.ok) {
 				// No filtering - workspace must be 100% clean
 				const unexpected_files = files_result.value;