fix package fetching error handling

Author: ryanatkn

.changeset/three-fireants-serve.md

@@ -0,0 +1,5 @@
+---
+'@ryanatkn/orc': patch
+---
+
+fix package fetching error handling

src/lib/fetch_packages.ts

@@ -5,19 +5,17 @@ import type {Logger} from '@grogarden/util/log.js';
 import {wait} from '@grogarden/util/async.js';
 import {parse_package_meta, type PackageMeta} from '@fuz.dev/fuz_library/package_meta.js';
 import {request} from '@octokit/request';
-import {GITHUB_TOKEN_SECRET} from '$env/static/private';
 
 // TODO rethink with `Package` and `FetchedPackage2`
-export interface FetchedPackage {
+export interface MaybeFetchedPackage {
 	url: Url;
 	package_json: PackageJson | null; // TODO forward error
-	pulls: GithubIssue[];
+	pulls: GithubIssue[] | null;
 }
 
 type GithubIssue = any; // TODO
 
-// TODO obviously bad names
-export interface FetchedPackage2 extends PackageMeta {
+export interface FetchedPackage extends PackageMeta {
 	pulls: GithubIssue[] | null;
 }
 
@@ -28,28 +26,33 @@ export interface UnfetchablePackage {
 }
 
 // TODO rethink these names
-export type FetchedPackageMeta = FetchedPackage2 | UnfetchablePackage;
+export type FetchedPackageMeta = FetchedPackage | UnfetchablePackage;
 
 /* eslint-disable no-await-in-loop */
 
 export const fetch_packages = async (
 	urls: Url[],
+	token?: string,
 	log?: Logger,
 	delay = 50,
-	token = GITHUB_TOKEN_SECRET,
-): Promise<FetchedPackage[]> => {
+): Promise<MaybeFetchedPackage[]> => {
 	console.log(`urls`, urls);
-	const packages: FetchedPackage[] = [];
+	const packages: MaybeFetchedPackage[] = [];
 	for (const url of urls) {
-		const package_json = await load_package_json(url, log);
-		if (!package_json) throw Error('failed to load package_json: ' + url);
-		await wait(delay);
-		const pkg = parse_package_meta(url, package_json);
-		if (!pkg) throw Error('failed to parse package_json: ' + url);
-		const pulls = await fetch_github_issues(url, pkg, log, token);
-		if (!pulls) throw Error('failed to fetch issues: ' + url);
-		await wait(delay);
-		packages.push({url, package_json, pulls});
+		try {
+			const package_json = await load_package_json(url, log);
+			if (!package_json) throw Error('failed to load package_json: ' + url);
+			await wait(delay);
+			const pkg = parse_package_meta(url, package_json);
+			if (!pkg) throw Error('failed to parse package_json: ' + url);
+			const pulls = await fetch_github_issues(url, pkg, log, token);
+			if (!pulls) throw Error('failed to fetch issues: ' + url);
+			await wait(delay);
+			packages.push({url, package_json, pulls});
+		} catch (err) {
+			packages.push({url, package_json: null, pulls: null});
+			log?.error(err);
+		}
 	}
 	return packages;
 };

src/lib/packages.json.d.ts

@@ -1,5 +1,5 @@
 declare module '$lib/packages.json' {
-	import type {FetchedPackage} from '$lib/fetch_packages.js';
-	const data: FetchedPackage[];
+	import type {MaybeFetchedPackage} from '$lib/fetch_packages.js';
+	const data: MaybeFetchedPackage[];
 	export default data;
 }

src/lib/packages.task.ts

@@ -6,8 +6,9 @@ import {format_file} from '@grogarden/gro/format_file.js';
 import {exists} from '@grogarden/gro/exists.js';
 import {join} from 'node:path';
 import {paths} from '@grogarden/gro/paths.js';
+import {GITHUB_TOKEN_SECRET} from '$env/static/private';
 
-import {fetch_packages, type FetchedPackage} from '$lib/fetch_packages.js';
+import {fetch_packages, type MaybeFetchedPackage} from '$lib/fetch_packages.js';
 import {load_orc_config} from '$lib/config.js';
 
 // TODO etags - cache?
@@ -40,13 +41,16 @@ export const task: Task<Args> = {
 		const orc_config = await load_orc_config(dir);
 		const {packages} = orc_config;
 
-		const fetched_packages = await fetch_packages(packages, log);
+		const fetched_packages = await fetch_packages(packages, GITHUB_TOKEN_SECRET, log);
 
 		const local_package_json = await load_package_json(dir);
 
-		const final_packages: FetchedPackage[] = local_package_json?.homepage
+		const final_packages: MaybeFetchedPackage[] = local_package_json?.homepage
 			? [
-					{url: local_package_json.homepage, package_json: local_package_json} as FetchedPackage,
+					{
+						url: local_package_json.homepage,
+						package_json: local_package_json,
+					} as MaybeFetchedPackage,
 			  ].concat(fetched_packages)
 			: fetched_packages;