Remove Kotlin/Jupyter Gradle plugin #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This integration format successfully avoids Kotlin Jupyter's dependency on dev versions of the Kotlin Gradle plugin (and the Kotlin compiler), which is failing #424. It has the downside that using Jupyter Testkit will no longer be possible. To proceed with this approach, DevelocityApiJupyterIntegrationTest tests will need to be migrated to actual notebooks, running via jupyter nbconvert as in the examplesTest suite. Original failure: https://scans.gradle.com/s/vy3gdlvqaolni On this commit: https://scans.gradle.com/s/zuuezcwirtteg
gabrielfeo
force-pushed
the
gf/avoid-kgp-dev-dependency
branch
from
2c58398 to
bcccb3c
Compare
Contributor
Job Summary for GradleCheck PR :: kotlin-tests
|
Contributor
Job Summary for GradleCheck PR :: kotlin-tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Kotlin Jupyter Gradle plugin in order to avoid its reliance on dev versions of the Kotlin Gradle plugin (and the Kotlin compiler). The original motivation for this was one Kotlin/Jupyter version that was relying on an unpublished KGP version, failing builds on #424.
That's since been resolved, but beta versions of KGP keep being used and I'd rather avoid publishing a library built with pre-release versions of KGP.
The integration that was previously facilitated by the plugin is now done manually.
examplesTestguarantees this is functional.