Fix publish javadoc #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Generated API diff |
gabrielfeo
force-pushed
the
fix-publish-javadoc
branch
from
a834576 to
1998f5f
Compare
gabrielfeo
force-pushed
the
fix-publish-javadoc
branch
from
1998f5f to
72be7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having a default value for
dry-runin the build action and checking for mere presence as!inputs.dry-run, the default was effectively true. As a result, the latest javadoc publishing failed.Change all conditions to check for
trueand letbuild-javadocupload artifacts even when dry-run, as it only matters thatpublish-javadocnot push them the branch afterwards.