Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Workflow Scheduling Test Cases #3555

Open
1 of 3 tasks
jmchilton opened this issue Feb 3, 2017 · 4 comments
Open
1 of 3 tasks

Implement Workflow Scheduling Test Cases #3555

jmchilton opened this issue Feb 3, 2017 · 4 comments

Comments

@jmchilton
Copy link
Member

jmchilton commented Feb 3, 2017

  • Make sure that cancelling a job that is causing workflow scheduling to delay, cancels the workflow scheduling.
  • Make sure that a job failing that is causing workflow scheduling to delay, fails the workflow scheduling.
  • Make sure that deleting a history that a workflow is scheduled to run against, cancels workflow scheduling.
@nsoranzo
Copy link
Member

nsoranzo commented Aug 24, 2017

Make sure that deleting a history that a workflow is scheduled to run against, cancels workflow scheduling.

This keeps happening on 17.05:

galaxy=> SELECT workflow_invocation.id AS wfi_id, workflow_invocation.state AS wfi_state, history.id as hid, history.name AS history_name, history.deleted FROM workflow_invocation JOIN history ON workflow_invocation.history_id = history.id WHERE history.deleted IS TRUE AND workflow_invocation.state NOT IN ('failed', 'scheduled') ORDER BY wfi_id;
 wfi_id | wfi_state | hid |            history_name             | deleted 
--------+-----------+-----+-------------------------------------+---------
    800 | ready     | 821 | GeneSeqToFamily on 23 and 22        | t
...
(13 rows)

An admin can fix them by running the following SQL query:

UPDATE workflow_invocation SET state = 'failed' WHERE id IN (SELECT workflow_invocation.id FROM workflow_invocation JOIN history ON workflow_invocation.history_id = history.id WHERE history.deleted IS TRUE AND workflow_invocation.state NOT IN ('failed', 'scheduled'));

@jmchilton jmchilton modified the milestones: 18.01, 17.09 Sep 5, 2017
jmchilton added a commit to jmchilton/galaxy that referenced this issue Sep 8, 2017
jmchilton added a commit to jmchilton/galaxy that referenced this issue Sep 8, 2017
With test case, rebased with spelling fixes thanks to @nsoranzo.

xref galaxyproject#3555 (third point)
jmchilton added a commit to jmchilton/galaxy that referenced this issue Sep 8, 2017
With test case, rebased with spelling fixes thanks to @nsoranzo.

xref galaxyproject#3555 (third point)
jmchilton added a commit to jmchilton/galaxy that referenced this issue Sep 11, 2017
With test case, rebased with spelling fixes thanks to @nsoranzo.

xref galaxyproject#3555 (third point)
jmchilton added a commit to jmchilton/galaxy that referenced this issue Sep 11, 2017
With test case, rebased with spelling fixes thanks to @nsoranzo.

xref galaxyproject#3555 (third point)
@jmchilton
Copy link
Member Author

Ping @RJMW...

I'd modify this a bit for your purposes and kill just the one invocation from your logs:

UPDATE workflow_invocation SET state = 'failed' WHERE id = 2;

@bgruening
Copy link
Member

Had this problem again with 17.09.

@martenson
Copy link
Member

I am clearing the milestone here.

@martenson martenson removed this from the 18.01 milestone Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants