Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] fix undefined error in ui-file-source #11586

Merged

Conversation

OlegZharkov
Copy link
Contributor

What did you do?

added undefined check in ui-file-source.js

Why did you make this change?

(If fixing a bug, please add any relevant error or traceback)

TypeError: this._value is undefined
_getValue ui-file-source.js:82
value ui-file-source.js:71
e form-data.js:90
create form-data.js:109
render form-view.js:104
initialize form-view.js:25
initialize tool-form-base.js:25
View libs.chunk.js:1
r libs.chunk.js:1
r libs.chunk.js:1
t forms.js:46
N utilities.js:87
onActivate Index.vue:240
zt libs.chunk.js:7
n libs.chunk.js:7
zt libs.chunk.js:7
$emit libs.chunk.js:7
setNode Node.vue:292
te libs.chunk.js:7
Yt libs.chunk.js:7
promise callbackHt libs.chunk.js:7
te libs.chunk.js:7
update libs.chunk.js:7
update libs.chunk.js:7
notify libs.chunk.js:7
set libs.chunk.js:7
set libs.chunk.js:7
setData Node.vue:299
initData Node.vue:307
setNode Node.vue:289
onUpdate Index.vue:253
promise callbackonUpdate Index.vue:251
...

How to test the changes?

For UI Components

  • I've included a screenshot of the changes

image

Co-authored-by: Dannon <dannon.baker@gmail.com>
@bgruening
Copy link
Member

The packaging error looks scary but seems unrelated. Can we merge that @dannon?

@dannon dannon merged commit f2d294a into galaxyproject:release_20.09 Mar 10, 2021
@OlegZharkov OlegZharkov deleted the 20.09-fix-ui-file-source branch March 10, 2021 15:03
@mvdbeek mvdbeek added this to the 21.05 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants