Front-end Library Routing refactor #11614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/libraries
OlegZharkov
force-pushed
the
lib-route-refactor
branch
from
24673d9
to
3fc8026
Compare
OlegZharkov
changed the title
dannon
reviewed
Mar 15, 2021
dannon
requested changes
Mar 15, 2021
apply wildcard in buildapp.py
|
Sorry @dannon, you were right. I've read a bit here and there, and figured it out. I probably shouldn't have argued about it and just done it right away. I hope it looks better now. Thanks a lot for checking it! |
|
@OlegZharkov No worries about a little bit of discussion man :) This looks like exactly what I was thinking of -- I'm really glad you jumped on it and knocked it before I could even follow up this evening! |
|
This PR was merged without a "kind/" label, please correct. |
dannon
added
kind/enhancement
kind/refactoring
|
can someone also add |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #11485 and will be a draft until 11485 is merged
What did you do?
Refactored library Router.
Why did you make this change?
The code looks cleaner, we don't need to define each possible library route in
buildapp.pyandAnalysisRouter.jsanymore,LibraryFolderRouterwill take care. Also it adds consistency in router naming.Additionally it fixes a following bug:
it was not possible to return into upper library folder with the 'back' browser button, this PR will fix this issue
How to test the changes?
Quite a few selenium tests are already in place
Go to libraries and surf, also use back <- and front -> buttons in your browser