Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.01] Patch to click the button which should be more stable #11838

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

hexylena
Copy link
Member

What did you do?

  • Replaced the now removed Galaxy.upload.show with clicking on the button

Why did you make this change?

This seems to have broken in 21.01, making the 'upload' button in tutorials accessed through this webhook non-functional

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. activate the webhook
    2. setup proxying (there's a link at the bottom that appears with documentation on the nginx configuration needed) / setup nginx / etc.
    3. activate webhook
    4. browse to a tutorial that uses the feature (e.g. assembly → the MRSA tutorials)
    5. Click on the blue 'import' button during the first hands-on box
    6. It should open the upload dialogue

License

For UI Components

  • I've included a screenshot of the changes

@bgruening bgruening merged commit a844e2b into galaxyproject:release_21.01 Apr 15, 2021
@bgruening bgruening deleted the patch-gtn-in-galaxy branch April 15, 2021 19:08
@bgruening
Copy link
Member

Thanks @hexylena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants