Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstraction for fetching qualified app URL across webapp types #11904

Merged
merged 5 commits into from
May 4, 2021

Conversation

jmchilton
Copy link
Member

What did you do?

  • Add abstraction for recovering URL.

Why did you make this change?

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@davelopez
Copy link
Contributor

This definitely looks like the way to a proper solution! Thank you so much for taking the time to look into it. I was lost in the matter 😄

The url_for function is used in quite a lot of places all over the code base so, simply deprecating it, doesn't seem feasible. Also, I'm not sure if the FastAPI/Starlette version of url_for has the same signature/interface as the old one 🤔

@jmchilton jmchilton force-pushed the url_for branch 2 times, most recently from 5585ac7 to 2036b37 Compare April 28, 2021 13:36
@jmchilton jmchilton changed the title [WIP] Abstraction for fetching qualified app URL across webapp types Abstraction for fetching qualified app URL across webapp types Apr 30, 2021
@github-actions github-actions bot added this to the 21.05 milestone Apr 30, 2021
@jmchilton jmchilton changed the title Abstraction for fetching qualified app URL across webapp types [WIP] Abstraction for fetching qualified app URL across webapp types Apr 30, 2021
@davelopez davelopez mentioned this pull request May 3, 2021
6 tasks
@jmchilton jmchilton changed the title [WIP] Abstraction for fetching qualified app URL across webapp types Abstraction for fetching qualified app URL across webapp types May 3, 2021
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @jmchilton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants