Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.01] add GALAXY_MEMORY_MB* to passt hrough #12039

Merged
merged 1 commit into from
May 24, 2021

Conversation

bgruening
Copy link
Member

What did you do?

Its passes "GALAXY_MEMORY_MB" and "GALAXY_MEMORY_MB_PER_SLOT" inside containers. Currently only GALAXY_SLOTS, HOME and a few TEMP dirs are passed through.

Why did you make this change?

I found container tools that did not use the specified GALAXY_SLOTS.

How to test the changes?

Run a Docker enabled Tool and check if GALAXY_MEMORY_MB is set via the -e variables.

License

@bgruening bgruening changed the title add GALAXY_MEMORY_MB* to passt hrough [21.01] add GALAXY_MEMORY_MB* to passt hrough May 23, 2021
@github-actions github-actions bot added this to the 21.05 milestone May 23, 2021
@bgruening
Copy link
Member Author

@natefoo that might be interesting for you.

Copy link
Member

@natefoo natefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably ought to actually set those limits on the container directly as well, but this is definitely a good move. Thanks @bgruening!

@bgruening
Copy link
Member Author

We probably ought to actually set those limits on the container directly as well, but this is definitely a good move.

Yes we should. I seem container escape our general cgroup monitoring otherwise. I saw jobs reporting only 1GB max-memory usage, but they used in the Docker processes much more.

@jmchilton jmchilton merged commit 572584c into galaxyproject:release_21.01 May 24, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the galaxy_memory branch May 24, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants