[21.05] Fix name of datasets with invalid contents #12107

mvdbeek · 2021-06-08T16:44:54Z

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these contributions under Galaxy's current license.
I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to galaxy-committers@lists.galaxyproject.org.

bgruening

Thanks! Also for the test!

mvdbeek added 2 commits June 8, 2021 18:37

Add fetch_data test for invalid html content

8271bb4

Only overwrite dataset name if there is a new name

2277727

Fixes galaxyproject#12008

mvdbeek changed the base branch from dev to release_21.05 June 8, 2021 16:45

mvdbeek changed the title ~~Fix name of datasets with invalid contents~~ [21.05] Fix name of datasets with invalid contents Jun 8, 2021

github-actions bot added area/testing area/testing/api labels Jun 8, 2021

github-actions bot added this to the 21.09 milestone Jun 8, 2021

mvdbeek added the kind/bug label Jun 8, 2021

jmchilton approved these changes Jun 8, 2021

View reviewed changes

bgruening approved these changes Jun 9, 2021

View reviewed changes

bgruening merged commit b4bbffe into galaxyproject:release_21.05 Jun 9, 2021

mvdbeek mentioned this pull request Jun 9, 2021

Invalid file upload causes missing file name in History panel #12008

Closed

mvdbeek modified the milestones: 21.09, 21.05 Jun 10, 2021