fixed $defaults according to #2430 #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/enhancement
status/review
area/tool-framework
and removed
triage
labels
|
Seems like a good idea, thanks! |
|
@galaxybot test this |
|
@jmchilton I think the failing test is unrelated: |
| @@ -303,6 +306,9 @@ def add_var(name, value): | |||
| else: | |||
| defaults = "$galaxy_root:ro,$tool_directory:ro,$working_directory:rw,$default_file_path:rw" | |||
|
|
|||
| if self.app_info.library_import_dir: | |||
| defaults = defaults + ",$library_import_dir:ro" | |||
There was a problem hiding this comment.
Could be also:
defaults += ",$library_import_dir:ro"But I guess it depends on how much you want your code to be obvious :)
|
Thanks @ThomasWollmann! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.