Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed $defaults according to #2430 #2438

Merged
merged 2 commits into from Jun 3, 2016

Conversation

Projects
None yet
5 participants
@ThomasWollmann
Copy link
Contributor

commented May 31, 2016

No description provided.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

Seems like a good idea, thanks!

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

@galaxybot test this

@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

@jmchilton I think the failing test is unrelated: ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

@@ -303,6 +306,9 @@ def add_var(name, value):
else:
defaults = "$galaxy_root:ro,$tool_directory:ro,$working_directory:rw,$default_file_path:rw"

if self.app_info.library_import_dir:
defaults = defaults + ",$library_import_dir:ro"

This comment has been minimized.

Copy link
@remimarenco

remimarenco Jun 1, 2016

Contributor

Could be also:

defaults += ",$library_import_dir:ro"

But I guess it depends on how much you want your code to be obvious :)

@bgruening bgruening merged commit 697b01c into galaxyproject:dev Jun 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented Jun 3, 2016

Thanks @ThomasWollmann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.