Updates to Interactive Environment docs #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move docs on writing IEs to developer docs
| docker containers. Once this container is launched, we notify a proxy built | ||
| into Galaxy which helps coordinate a 1:1 mapping of users and their docker containers. | ||
| component. Galaxy vizualisation plugins are rendered using Mako templates and | ||
| Mako templates in turn can run Python code. This Python code in the Mako templates |
There was a problem hiding this comment.
"code. This" -> "code. GIEs build upon visualization plugins, adding features to allow for container management and proxying. This"
hexylena
added
kind/enhancement
area/documentation
area/interactive-tools
status/review
and removed
triage
labels
|
Also you'll need to mention this in docs/dev/index.rst or something, I think |
| location /galaxy/gie_proxy/ipython/api/kernels { | ||
| proxy_pass http://localhost:8800/galaxy/gie_proxy/ipython/api/kernels; | ||
| location ~ ^/galaxy/gie_proxy/jupyter/(?<nbtype>[^/]+)/api/kernels(?<rest>.*?)$ { | ||
| proxy_pass http://localhost:8800/galaxy/gie_proxy/$nbtype/api/kernels$rest; |
There was a problem hiding this comment.
@bgruening, @pvanheus says this is correct and I believe him, but just wanted a second opinion :)
|
After @bgruening replies, ready to merge |
| @@ -3,21 +3,23 @@ Galaxy Interactive Environments (GIEs) | |||
|
|
|||
| GIEs were a new feature back in Galaxy 15.05, leading with the release of the | |||
| IPython IE. They were presented at GCC2015, and the RStudio IE was released as | |||
| part of 15.07. | |||
| part of 15.07. The IPython IE was superceded by a Project Jupyter IE in | |||
| Galaxy XXXXX. | |||
There was a problem hiding this comment.
ping @pvanheus
Thanks for enhancing it!
|
Awesome - thanks for the continued improvements to docs @pvanheus! |
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Oct 24, 2016
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Oct 24, 2016
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add updates to the Interactive Environment docs and split out the docs on writing IEs to developer documentation.