Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Collection Operation to Relabelling Identifiers #3603

Merged

Commits on Apr 14, 2017

  1. Start work on a relabelling collection operation.

    I think it needs to be touched up but the basic operation seems to work so far. I think what remains to be done is:
    
     - Validate uniqueness of identifiers and provide nice messages if they are not unique.
     - Validate that at least the required number of lines are present in the file and provide a nice message if not.
     - Add strict mode to ensure exactly the correct number of lines is added.
     - Find where validation of identifiers happens in the API and apply same validation here - try not to let unsafe identifiers be created.
     - Consider more advanced modes - selecting a column, apply a regex replace, pick two columns for nested lists, etc.... None of this may need to be needed in the first iteration.
     - Consider another mode where a collection is labelled against an existing collection - should that be a separate tool of the same tool.
    jmchilton committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    9b6a9dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d21c14f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    338130a View commit details
    Browse the repository at this point in the history
  4. Various improvements to relabel from file collection operation.

    - Better error handling (check for bad characters when creating collections).
    - Implement a strict mode parameter to do even more validation.
    - Rework tabular vs txt mode to be explicit user choice.
    - Mirror fix in release_17.01 for datasets not having a history,
    jmchilton committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    09bcdd9 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2017

  1. Configuration menu
    Copy the full SHA
    2288a88 View commit details
    Browse the repository at this point in the history