[17.05] Try activating conda environment again if previous activation failed #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea @mvdbeek! 👍 |
nsoranzo
reviewed
May 5, 2017
| while [ $COUNT -lt $MAX_TRIES ]; do | ||
| . %s '%s' > conda_activate.log 2>&1 | ||
| if [ $? -eq 0 ];then | ||
| break |
| sleep 10s | ||
| let COUNT=COUNT+1 | ||
| fi | ||
| done """ |
There was a problem hiding this comment.
I think this may not have exit code 1 if the activation fails all 3 times.
There was a problem hiding this comment.
That's right, it will just continue and fail with command not found, which is OK, no ?
mvdbeek
force-pushed
the
retry_conda_activation
branch
from
1bb192b
to
c38c027
Compare
|
Thanks @mvdbeek - this seems like a good idea. I have mixed feelings on the explicit exit - it isn't something we have done in the past but it is probably better to be explicit here. |
|
This PR was merged without a milestone attached. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should resolve #4031.