Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] Add Loom datatype and remove rdata.seurat #6723

Merged
merged 2 commits into from
Sep 18, 2018
Merged

[18.09] Add Loom datatype and remove rdata.seurat #6723

merged 2 commits into from
Sep 18, 2018

Conversation

blankenberg
Copy link
Member

No description provided.

@blankenberg blankenberg added this to the 18.09 milestone Sep 17, 2018
@nsoranzo nsoranzo changed the title Add Loom datatype and remove rdata.seurat. [18.09] Add Loom datatype and remove rdata.seurat Sep 17, 2018
@jxtx
Copy link
Contributor

jxtx commented Sep 17, 2018

image

bgruening
bgruening approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blankenberg! Looks good to me.
@mblue9 any objections to remove rdata.seurat in favor of loom for this release?

Not sure why tests are failing :(

@mblue9
Copy link
Contributor

mblue9 commented Sep 18, 2018

Fine by me 👍

@dannon
Copy link
Member

dannon commented Sep 18, 2018

Rerunning the integration tests to see what's up.

@mvdbeek
Copy link
Member

mvdbeek commented Sep 18, 2018

The previous integration passed but didn't shut down correctly. The error now is unrelated.

@dannon
Copy link
Member

dannon commented Sep 18, 2018

@mvdbeek Yeah, I dug through, too, and it looked unrelated to me. Queued it for another run just to see what happens with that test, though

@dannon dannon merged commit 8462df8 into galaxyproject:release_18.09 Sep 18, 2018
@dannon
Copy link
Member

dannon commented Sep 18, 2018

The data manager test that failed before passed this time, too! We'll have to track that down some other time.

@blankenberg
Copy link
Member Author

Off topic, but worth burning an hour of time...

@blankenberg blankenberg deleted the 18.09-loom branch September 18, 2018 18:15
@blankenberg
Copy link
Member Author

Thanks all for the comments, reviews, and getting the tests to finally pass, I had started to give up after the 3rd-or-so unrelated failure.

@galaxyproject galaxyproject deleted a comment from galaxybot Sep 18, 2018
@blankenberg blankenberg mentioned this pull request Sep 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
area/datatypes kind/feature
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.
7 participants
@blankenberg @jxtx @mblue9 @dannon @mvdbeek @bgruening @martenson