Feat: New help tooltips (phase 1) #2679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
|
Size Change: -6.67 kB (0%) Total Size: 2.12 MB
ℹ️ View Unchanged
|
* removed tooltip for accordion control * replaced tooltip for image size * replaced tooltips of position * replaced tooltips in background controls * replaced tooltip for borders * replaced tooltips of size controls * replaced tooltips in image controls * added tooltips for progress bar color controls * replaced tooltip for shadow control * added help tooltips for flexbox features * removed old tooltip implementation * revert deletion of help videos This reverts commit 7bdc8bd. * transfered videos to new folder * removed old dependency of help * added tooltip for column spacing * added video and proper description * added videos and descriptions * added tooltip support for advance toggle component * added videos to be used for tooltips * removed videos from old help implementation * removed tests * transferred deprecated background controls * transferred deprecated button controls and social controls * transferred deprecated column padding controls * transferred deprecated icon controls * transferred deprecated image background controls * transferred deprecated image controls * updated source of dependency * transferred image shape controls * transferred deprecated panel spacing body control * transferred deprecated typography control helper * added tooltips for typography controls * added tooltip support for autosuggest * added help tooltips for button controls * added help tooltips for image controls * helpTooltip is now a dynamic value * added tooltips for separator controls * added videos * removed classname * removed deprecated classnames * added tooltip for accordion controls * added tooltips for old typography component * added tooltips for column and alignment controls * added tooltips for posts controls * added comments * deleted unused videos --------- Co-authored-by: prconcepcion <pioconcepcion3@yahoo.com> Co-authored-by: Benjamin Intal <benjaminintal@Benjamins-MacBook-Pro.local>
fix (tooltips): fixed issues found from QA testing and user testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated implementation of our inspector help tooltips. This should completely replace our old tooltip system.
TODO
helpTooltipprop across all inspector control componentsclassName="ugb--help-tip-xxx"should be removed)src/help/*except the welcome help)@prconcepcion I added
TODOcode comments as guides in the PRBackground
Our previous implementation was hacky and relied on adding
className="ugb--help-tip-xxx"to controls. When the className pattern is detected, we add DOM event listeners to the element (the hacky part).Now the new implementation is directly added into our base control component by adding a
helpTooltipprop that provides all the information about the tooltip to display.All the videos are in a central area so that they're not scattered across the codebase, this also makes it easier to deploy the videos in the cloud for production. Each video name should be unique and describe the help tooltip, e.g.
button-shadowFixes #2710