chore: #324 Fix type check of staged files

[timagixe]

Changes

• Closes Fix getting-started.tsx type check #324
• Move --skipLibCheck CLI flag to tsconfig.json
• Run typecheck script on pre-commit instead of tsc with custom compilerOption flags

Checklist

• Read the contribution guide and accept the
  code of conduct
• Readme - not needed
• Tests - not needed

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
website	✅ Ready (Inspect)	Visit Preview	Sep 5, 2022 at 10:17AM (UTC)

[github-actions]

[webbertakken]

This will check all files instead of only staged files.

Ideally precommit checks are blazing fast.

How long does the typecheck take for all files? This change is in the right direction, however, if it takes longer than a second or two we should probably create a follow-up to make it process staged files only.

[timagixe]

@webbertakken

It takes 7.56s for me to complete full project typecheck.

% yarn typecheck                
yarn run v1.22.19
$ tsc
✨  Done in 7.49s.

We can consider using this small wrapper (tsc-files) around tsc that helps run tsc on staged files without ignoring tsconfig.json. Let me know what do you think of it.

[webbertakken]

@timagixe I think that would be the most elegant solution indeed, short of removing the whole hook entirely.

If you're able to get that to work with lefthook that would be amazing.

If lefthook is causing trouble somehow, know that I'm also planning to move our repos back to lint-staged and husky since their cross platform support now properly works again.

[timagixe]

@webbertakken I have set up tsc-files, please take a look when you have a chance.

[webbertakken]

Thank you very much @timagixe

[timagixe]

My pleasure @webbertakken 🙌