versioning 'Tag' causes an error on build.gradle

[estellise-yukihime]

Bug description

Warning: Could not parse "1.0.5
" to semver, defaulting android version code to 1

FAILURE: Build failed with an exception.

* Where:
Build file '/github/workspace/Temp/gradleOut/launcher/build.gradle' line: 26

* What went wrong:
Could not compile build file '/github/workspace/Temp/gradleOut/launcher/build.gradle'.
> startup failed:
  build file '/github/workspace/Temp/gradleOut/launcher/build.gradle': 26: expecting ''', found '\n' @ line 26, column 27.
             versionName '1.0.5
                               ^
  
  1 error

Additional details

Sample Project

Tested only on unity versions

• 2019.4.12f1
• 2020.3.10f1

[webbertakken]

Thank you for reporting this bug.

It might be related to a missing trim here

unity-builder/src/model/versioning.ts

Line 268 in 3ebdb0e

return this.git(['tag', '--points-at', 'HEAD']);

[RaadDalaq]

Thank you for reporting this bug.

It might be related to a missing trim here

unity-builder/src/model/versioning.ts

Line 268 in 3ebdb0e

return this.git(['tag', '--points-at', 'HEAD']);

Yep, we fixed it on our side by just trimming the version before assigning it in unity.

[webbertakken]

@RaadDalaq would you be willing to create a PR for that?

[RaadDalaq]

@webbertakken It was through our unity C# build pipeline, not sure if it's applicable, we didn't modify the repo, I can try and fix it in my fork later, just a bit busy currently.

[estellise-yukihime]

Thank you for reporting this bug.

It might be related to a missing trim here

unity-builder/src/model/versioning.ts

Line 268 in 3ebdb0e

return this.git(['tag', '--points-at', 'HEAD']);

I see, thank you, for now, I just tried to trim on versioning.ts it, and currently just works perfectly on my end.

[webbertakken]

Great @estellise-yukihime. would you be willing to create a PR for that?

[estellise-yukihime]

Great @estellise-yukihime. would you be willing to create a PR for that?

I can, but this is only a 1 line fix and this is my 1st time doing typescript I don't know if what I did is the correct way.

[estellise-yukihime]

@webbertakken, This is the PR - 287.

[webbertakken]

Fixed by #287 in https://github.com/game-ci/unity-builder/releases/tag/v2.0-alpha-13.

Please feel free to comment if the issue is in fact not resolved.