Add support for android builds #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 14 14
Lines 245 245
Branches 47 47
=======================================
Hits 232 232
Misses 13 13 |
Merged
|
This one now has conflicts because of last merge. I'll merge it when you rebase this and generate the new index file (yarn build) |
webbertakken
requested changes
Jun 19, 2020
.github/workflows/main.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| name: Actions 😎 | |||
| name: Build and Tests | |||
There was a problem hiding this comment.
Could you leave this as actions just without the emoji? it'll look more readable in this view:
Note that this will also affect the badge in the readme.
The emoji in the github action name exposed as a env variable through docker was causing a gradle crash 😢.
|
@webbertakken rebased and addressed the feedback. Thanks for taking the time to reviews these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emoji in the github action name exposed as a env variable through docker was causing a gradle crash 😢.
This PR depends on #105, DO NOT MERGE until after #105 is landed.