Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action/index.js

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions src/jest.setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,24 @@ expect.extend({
pass,
};
},

toBeParsableToANumber(received) {
let pass = false;
let errorMessage = '';

try {
Number.parseInt(received, 10);
pass = true;
} catch (error) {
errorMessage = error;
}

const message = () => `Expected ${this.utils.printExpected(received)} to be parsable as a number
, but received error: ${this.utils.printReceived(errorMessage)}.`;

return {
message,
pass,
};
},
});
8 changes: 8 additions & 0 deletions src/model/system.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,13 @@ describe('System', () => {
expect(info).toHaveBeenCalledTimes(2);
expect(info).toHaveBeenLastCalledWith('3\n');
});

it('allows pipes using buffer', async () => {
await expect(
System.run('sh', undefined, {
input: Buffer.from('git tag --list --merged HEAD | grep v[0-9]* | wc -l'),
}),
).resolves.toBeParsableToANumber();
});
});
});
18 changes: 7 additions & 11 deletions src/model/versioning.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,18 +183,14 @@ export default class Versioning {
* Whether or not the repository has any version tags yet.
*/
static async hasAnyVersionTags() {
const numberOfVersionCommits = await System.run('git', [
'tag',
'--list',
'--merged',
'HEAD',
'|',
'grep v[0-9]*',
'|',
'wc -l',
]);
const numberOfCommitsAsString = await System.run('sh', undefined, {
input: Buffer.from('git tag --list --merged HEAD | grep v[0-9]* | wc -l'),
silent: false,
});

const numberOfCommits = Number.parseInt(numberOfCommitsAsString, 10);

return numberOfVersionCommits !== '0';
return numberOfCommits !== 0;
}

/**
Expand Down