-
Notifications
You must be signed in to change notification settings - Fork 3
Fix skipped integration tests #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes six skipped integration tests by resolving a version comparison bug that occurred when comparing versions with different precision levels (e.g., "6.0" vs "6.0.3"). Additionally, it addresses an unrelated issue in model parameter handling for mixed value/unit lists.
- Introduces new version comparison functions that can handle different version precision levels
- Fixes model parameter value retrieval for mixed lists containing both values and units
- Updates integration test configurations to use consistent version formats
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/simtools/version.py | Adds version comparison functions with configurable precision levels |
| src/simtools/testing/configuration.py | Updates test skipping logic to use new version comparison |
| src/simtools/model/model_parameter.py | Fixes parameter value handling for mixed value/unit lists |
| tests/unit_tests/test_version.py | Adds comprehensive tests for new version comparison functions |
| tests/unit_tests/model/test_model_parameter.py | Adds test for the new quantity creation helper method |
| tests/integration_tests/config/*.yml | Updates version format consistency |
| src/simtools/simtel/simulator_light_emission.py | Removes label parameter from output directory call |
| docs/changes/1805.bugfix.md | Documents the bug fixes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GernotMaier , all good.
|
Thanks @tobiaskleiner |




Six integration tests are skipped due to a bug in the model version comparison. This PR fixes this.
Required to fix an additional issue completely unrelated (but which led to failed unit tests):
value = [5., "abc"]andunit = ["cm", None]