Skip to content

Conversation

@ByteOtter
Copy link
Contributor

@ByteOtter ByteOtter commented Aug 12, 2025

What this PR does / why we need it:

This PR aims to push the few remaining modules' test coverage above an average of 85%.
In addition, I adjusted the coverage CI fail threshhold to the recommended 85%.

Which issue(s) this PR fixes:
Fixes #138 #163

@ByteOtter ByteOtter changed the title Push Test Coverage over 85% and adjust CI goal [Tests/CI] Push Test Coverage over 85% and adjust CI goal Aug 12, 2025
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.86%. Comparing base (39f7529) to head (ae40522).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   85.23%   90.86%   +5.62%     
==========================================
  Files          27       27              
  Lines        1226     1226              
==========================================
+ Hits         1045     1114      +69     
+ Misses        181      112      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ByteOtter ByteOtter force-pushed the tests/improve-coverage branch from d6a6c51 to bca9724 Compare August 12, 2025 15:03
@ByteOtter ByteOtter marked this pull request as ready for review August 12, 2025 15:06
@ByteOtter ByteOtter marked this pull request as draft August 12, 2025 15:08
@ByteOtter ByteOtter force-pushed the tests/improve-coverage branch 2 times, most recently from 93a6a52 to c912c4c Compare August 13, 2025 10:27
@ByteOtter ByteOtter force-pushed the tests/improve-coverage branch 2 times, most recently from e30a422 to c0abfec Compare August 13, 2025 12:35
@ByteOtter ByteOtter force-pushed the tests/improve-coverage branch from c0abfec to ae40522 Compare August 13, 2025 12:41
@ByteOtter ByteOtter marked this pull request as ready for review August 13, 2025 12:43
@ByteOtter ByteOtter requested a review from yeoldegrove August 13, 2025 12:46
Copy link
Contributor

@yeoldegrove yeoldegrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this large test coverage.

@yeoldegrove yeoldegrove merged commit 568cfa2 into main Aug 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better Test coverage

3 participants