Skip to content

Conversation

@NotTheEvilOne
Copy link
Contributor

What this PR does / why we need it:
This PR adds support to generate container names and tags in a generalized way for GardenLinux.

Which issue(s) this PR fixes:
Related gardenlinux/gardenlinux#3695

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.63%. Comparing base (df923f9) to head (66bad29).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gardenlinux/features/__main__.py 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   90.23%   90.63%   +0.40%     
==========================================
  Files          42       42              
  Lines        1997     2008      +11     
==========================================
+ Hits         1802     1820      +18     
+ Misses        195      188       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@yeoldegrove yeoldegrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests make me confident that this will work.

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>
@NotTheEvilOne NotTheEvilOne force-pushed the feature/support-container-names-and-tags branch 4 times, most recently from 1bfffa5 to 2967acb Compare November 4, 2025 15:29
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
On-behalf-of: SAP <tobias.wolf@sap.com>
@NotTheEvilOne NotTheEvilOne force-pushed the feature/support-container-names-and-tags branch from 2967acb to 66bad29 Compare November 4, 2025 16:07
@NotTheEvilOne NotTheEvilOne merged commit bb0645b into main Nov 4, 2025
7 of 10 checks passed
@NotTheEvilOne NotTheEvilOne deleted the feature/support-container-names-and-tags branch November 4, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants